fix: do not overwrite user-defined process's exit code to 1#338
Open
micalevisk wants to merge 1 commit intoevanw:masterfrom
Open
fix: do not overwrite user-defined process's exit code to 1#338micalevisk wants to merge 1 commit intoevanw:masterfrom
micalevisk wants to merge 1 commit intoevanw:masterfrom
Conversation
Instead of exiting with 1 we must keep the user-land value defined for `process.exitCode` if it's non-zero otherwise we end up changing the error code defined by the consumer of this lib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of exiting with 1 we must keep the user-land value defined for
process.exitCodeif it's non-zero otherwise we end up changing the error code defined by the consumer of this lib.Code example:
after running
node app.jsI'm expecting to see123as the exit code but I'm getting1: